leanprover-community / leanprover-community/mathlib4
non-reducibly-defeq coercions from LinearEquiv to LinearMap
Nobody has claimed this yet.
- Dominant language
- Lean
- Stars
- 4.1k
- Forks
- 1.7k
- PR merge metrics
- No merged PRs in 30d
Description
One is via SemilinearMapClass.instCoeToSemilinearMap, the other is via LinearEquiv.instCoeLinearMap; I think we should remove the latter.
This line
https://github.com/leanprover-community/mathlib4/blob/6e708dc8be75d27f10bf6c0c76ed0b76760ecc50/Mathlib/Algebra/Module/Equiv/Defs.lean#L51
may also be doing something.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Compare SemilinearMapClass.instCoeToSemilinearMap in Mathlib/Algebra/Module/LinearMap/Defs.lean with LinearEquiv.instCoeLinearMap in Mathlib/Algebra/Module/Equiv/Defs.lean. Inspect the referenced line near Equiv/Defs.lean:51 and confirm which coercion should remain. Done means the duplicate non-reducibly-defeq coercion is removed without breaking affected uses.
Written by the indexing model from the issue text.
Assessment
- Domain
- compilers
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100