leanprover-community / leanprover-community/mathlib4
protect `id`s
Open
Nobody has claimed this yet.
tech debt
- Dominant language
- Lean
- Stars
- 4.1k
- Forks
- 1.7k
- PR merge metrics
- No merged PRs in 30d
Description
RingHom.id, LinearMap.id are not protected, which makes it occassionally necessary to write _root_.id for id.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the linked RingHom.id and LinearMap.id declarations in the mathlib documentation, then inspect their source definitions and nearby naming conventions. Protect both declarations and verify that ordinary uses of id no longer require root.id, checking the affected references or project tests afterward.
Written by the indexing model from the issue text.
Assessment
- Domain
- backend-api-design
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 58/100