leanprover-community / leanprover-community/mathlib4
Refactor field theory using `IsConjRoot`
Nobody has claimed this yet.
- Dominant language
- Lean
- Stars
- 4.1k
- Forks
- 1.7k
- PR merge metrics
- No merged PRs in 30d
Description
As suggested in the PR review of #17783, there is a task of refactoring theorem statements in field theory using IsConjRoot.
Currently the definition of IsConjRoot is later than most of the field theory files, and all the results are located in one file. It could be moved to a much earlier place (immediately following the definition of minpoly). And we can spread these results to the proper place where they are first proved among field theory files.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the definition of minpoly and IsConjRoot, the surrounding field theory files, and PR #17783's review. Trace where the existing IsConjRoot results are currently located and where they are first proved; done means the definition is moved earlier, theorem statements use it, and results are placed with their first proofs.
Written by the indexing model from the issue text.
Assessment
- Domain
- devtools
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100