leanprover-community / leanprover-community/mathlib4

Regression after disabling `ConcreteCategory.instFunLike` as a global instance

Open
#13,342 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Lean
Stars
4.1k
Forks
1.7k
PR merge metrics
No merged PRs in 30d

Description

#13170 disables the accidentally global instance ConcreteCategory.instFunLike. This results in some rws and simps being replaced by erw 

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Read #13170 and inspect the effects of disabling ConcreteCategory.instFunLike on the affected rw and simp uses. Confirm which cases now require erw, then identify a focused change that restores the intended rw or simp behavior without the global instance; done means those regressions no longer require erw.

Written by the indexing model from the issue text.

Assessment

Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.