leanprover-community / leanprover-community/mathlib4
Porting note: unimplemented instance_priority linter
Nobody has claimed this yet.
- Dominant language
- Lean
- Stars
- 4.2k
- Forks
- 1.7k
- PR merge metrics
- No merged PRs in 30d
Description
This issue is tracking all porting notes referring to the instance_priority linter from mathlib3:
as this linter has not been ported to mathlib4 yet, the nolint entries from mathlib3 are commented. Porting notes look like
Steps to fix
- port the linter
- see which of the previous
nolints are required: uncomment the necessary ones and delete the now-superfluous ones.
Remove the porting note in either case. - deal with any new errors in mathlib4
- land the linter and rejoice :-)
Note. There are just five such porting notes. Perhaps this issue can also serve as a tracking issue for this particular linter.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the porting note in Mathlib/Algebra/Algebra/Hom.lean and locate the five notes referring to instance_priority. Port the linter, then determine which nolint entries remain necessary, remove each porting note, and address any new mathlib4 errors before landing the linter.
Written by the indexing model from the issue text.
Assessment
- Domain
- tooling
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100