leanprover-community / leanprover-community/mathlib4
`to_additive` should translate the names of recursor arguments in `elab_as_elim`
Open
Nobody has claimed this yet.
t-algebra
t-meta
- Dominant language
- Lean
- Stars
- 4.2k
- Forks
- 1.7k
- PR merge metrics
- No merged PRs in 30d
Description
Without this we get nonsense like
induction ha using AddSubmonoid.closure_induction' with
| mem => _
| one => _
| mul => _
instead of
induction ha using AddSubmonoid.closure_induction' with
| mem => _
| zero => _
| add => _
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the elab_as_elim entry point and tracing how to_additive translates recursor argument names. Reproduce the shown closure_induction' example, then verify that one and mul become zero and add in the generated induction alternatives.
Written by the indexing model from the issue text.
Assessment
- Domain
- compilers
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100