leanprover-community / leanprover-community/mathlib4
Diamonds at `reducible_and_instances` transparency
Open
Nobody has claimed this yet.
- Dominant language
- Lean
- Stars
- 4.1k
- Forks
- 1.7k
- PR merge metrics
- No merged PRs in 30d
Description
There are diamonds at the transparency settings used by typeclass synthesis and simp which are fine at default transparency.
Some have checks in the file which use := rfl and not := by with_reducible_and_instances rfl.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the transparency settings used by typeclass synthesis and simp, then inspect the checks that use := rfl. Update the affected checks to account for reducible_and_instances transparency and verify that the checks still pass.
Written by the indexing model from the issue text.
Assessment
- Domain
- tooling
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100