leanprover-community / leanprover-community/mathlib4
Dot-notation for theorems that don't have the struct in the assumptions
Open
Nobody has claimed this yet.
- Dominant language
- Lean
- Stars
- 4.2k
- Forks
- 1.7k
- PR merge metrics
- No merged PRs in 30d
Description
Given a structure Foo we usually have a theorem foo_zero : Foo 0. This should be renamed to Foo.zero so that in the namespace Foo one can use .zero.
- Go through the library and rename
foo_zerotoFoo.zero - Document the change in https://leanprover-community.github.io/contribute/naming.html
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the theorem naming guidance at https://leanprover-community.github.io/contribute/naming.html and the library-wide occurrences of the foo_zero pattern. Rename applicable theorems to Foo.zero, verify that uses continue to work in the Foo namespace, and update the naming documentation to describe the change.
Written by the indexing model from the issue text.
Assessment
- Domain
- developer-experience, documentation
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100