leanprover-community / leanprover-community/lean
Failures in get_peak_rss() should fail the application instead of silently returning 0
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 434
- Forks
- 79
- PR merge metrics
- No merged PRs in 30d
Description
Prerequisites
- Put an X between the brackets on this line if you have done all of the following:
- Checked that your issue isn't already filed.
- Specifically, check out the wishlist, open RFCs,
or feature requests.
- Specifically, check out the wishlist, open RFCs,
- Reduced the issue to a self-contained, reproducible test case.
- Checked that your issue isn't already filed.
Description
get_peak_rss() on FreeBSD was always failing due to a wrong /proc/... path and all tests still succeeded.
This function should be changed to hard-fail when any system call fails. In its current condition it might be silently failing for whatever reasons and users are never notified.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the get_peak_rss() entry point and inspecting how its system calls handle failures, especially on FreeBSD where the /proc/... path currently fails. Verify that every system-call failure is surfaced as an application failure rather than returning 0, and confirm that the existing tests no longer pass silently when resource lookup fails.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- operating-systems
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100