leanprover-community / leanprover-community/lean

more possible type class caching opportunities

Open
#467 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
434
Forks
79
PR merge metrics
No merged PRs in 30d

Description

There were some amazing performance increases earlier this year from improved instance caching. I just noticed another situation where redundant searches are performed. Note that I don't really know the implementation details here, so maybe there are reasons the cache can't be preserved here, but it seems plausible.

In the code below, add_comm assumes an add_comm_semigroup instance. The search from add_comm_group to add_comm_semigroup is repeated twice.

import algebra.group

set_option trace.class_instances true 
example {α} [add_comm_group α] (a b c : α) : (a + b) + c = c + (b + a) :=
begin 
  rw [add_comm, add_comm a],
end
Prerequisites
  • Put an X between the brackets on this line if you have done all of the following:
    • Checked that your issue isn't already filed.
    • Reduced the issue to a self-contained, reproducible test case.
Description

[Description of the issue]

Steps to Reproduce
  1. [First Step]
  2. [Second Step]
  3. [and so on...]

Expected behavior: [What you expect to happen]

Actual behavior: [What actually happens]

Reproduces how often: [What percentage of the time does it reproduce?]

Versions

You can get this information from copy and pasting the output of lean --version,
please include the OS and what version of the OS you're running.

Additional Information

Any additional information, configuration or data that might be necessary to reproduce the issue.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the embedded Lean reproducer in issue #467 and run it with set_option trace.class_instances true to confirm the repeated search. Then trace the type-class instance lookup implementation, which the issue does not identify, and determine whether preserving the cache is safe. Done means a validated caching approach with evidence that the redundant searches no longer occur.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
compilers
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.