leanprover-community / leanprover-community/lean
Emscripten build leftovers
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 433
- Forks
- 79
- PR merge metrics
- No merged PRs in 30d
Description
Here are some loose ends from #17:
-
There are a handful of tests that fail when running
ctestwith the emscripten build. -
If those get figured out, then as a followup we could look into adding back the tests to travis. A naïve approach takes way too long so we would have to break the emscripten build / test up into multiple phases. (See this comment).
-
There are warnings coming from the recent
vm_floatfeature (#2) that I haven't looked into:
emcc: warning: cannot represent a NaN literal '0x7fed6b0bae00' with custom bit pattern in NaN-canonicalizing JS engines (e.g. Firefox and Safari) without erasing bits!
in tail call fastcc void @_ZN4lean11mk_vm_floatEf(%"struct.std::__2::__compressed_pair_elem.26.1385"* noalias %0, float 0x7FF4000000000000) in _ZZN4lean19initialize_vm_floatEvENK3$_8clEv()
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by running ctest with the Emscripten build and compare the failing tests linked from #17. Then investigate whether the Emscripten build and tests can be split into Travis phases, and examine the vm_float warnings from #2. Done means the failing tests and warnings are understood and a workable CI approach is identified.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- build-system, ci-cd, testing
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100