leanprover-community / leanprover-community/iris-lean
Remove custom Instance of Countable
Nobody has claimed this yet.
- Dominant language
- Lean
- Stars
- 218
- Forks
- 63
- Avg merge
- 1d 23h
- Merged PRs (30d)
- 22
Description
Just flagging this as something we should watch out for. We currently define our own notion of countability which is not the same as Mathlib. We should NOT provide an instance from our version of countability to Mathlib's version as this would introduce non-definitional diamonds re. List. If mathlib ends up moving countability into batteries or stdlib, we should change over to that.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Review the repository's custom Countable definition and its relationship to Mathlib's Countable and List. Check whether Mathlib has moved countability into batteries or stdlib, while avoiding any instance bridge that could create non-definitional diamonds. Done means the project has a decided migration or monitoring plan without introducing the warned-about instance.
Written by the indexing model from the issue text.
Assessment
- Domain
- compilers
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Active
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100