leanprover-community / leanprover-community/iris-lean
Make OFE.hom an explicit subtype
Open
Nobody has claimed this yet.
Improvement
- Dominant language
- Lean
- Stars
- 218
- Forks
- 63
- Avg merge
- 1d 23h
- Merged PRs (30d)
- 22
Description
OFE.hom is a subtype. #177 (merging soon) adds nonexpansive coercions to and from the subtype to the CMRA on OFE.hom, indicating that these constructions may be redundant.
def Hom.toSubtype [OFE α] [OFE β] (f : α -n> β) : { f : α → β // NonExpansive f }
def Hom.ofSubtype [OFE α] [OFE β] (f : { f : α → β // NonExpansive f }) : α -n> β
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at OFE.hom and compare the Hom.toSubtype and Hom.ofSubtype definitions with the changes described in #177. Determine how making OFE.hom an explicit subtype affects these constructions, then verify that the resulting representation and affected uses match the issue’s stated goal.
Written by the indexing model from the issue text.
Assessment
- Domain
- tooling
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 52/100