lean-ja / lean-ja/lean-by-example
ToString など、export されている型クラスに登録する関数は protected にすべき
Open
Nobody has claimed this yet.
メモ
要調査
- Dominant language
- Lean
- Stars
- 188
- Forks
- 15
- Avg merge
- 9h 8m
- Merged PRs (30d)
- 6
Description
そうでないと open している名前空間によっては曖昧さが生じてめんどい
紹介するコード例でもこれは守った方がいいかもなあ(そもそもそれを指摘する Linter があってほしい気もする)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
The issue does not name any files, examples, tests, or entry points. First locate the examples that register functions with exported type classes and determine which declarations should be protected. Done means the affected examples avoid the reported namespace ambiguity and consistently follow the proposed convention.
Written by the indexing model from the issue text.
Assessment
- Domain
- documentation
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100