ldtteam / ldtteam/Structurize

[BUG] Builder does not consume the correct amount of items

Open
#674 3 comments 0 reactions 1 assignee View on GitHub

@Raycoms is already working on this.

Since Sep 21, 2024.

Bug
Dominant language
Java
Stars
55
Forks
53
Avg merge
20m
Merged PRs (30d)
1

Description

Is there an existing issue for this?
  • I have searched the existing issues
Are you using the latest MineColonies Version?
  • I am running the latest beta version of MineColonies for my Minecraft version.
Did you check on the Wiki? or ask on Discord?
  • I checked the MineColonies Wiki and made sure my issue is not covered there. Or I was sent from discord to open an issue here.
What were you playing at the time? Were you able to reproduce it in both settings?
  • Single Player
  • Multi Player
Minecraft Version

1.20.1

MineColonies Version

1.1.586-BETA

Structurize Version

1.0.733-RELEASE

Related Mods and their Versions
  1. Forge Version: 47.1.3 2. JEI Version: 15.2.0.21 3. BlockUI Version: 1.0.139-BETA 4. DO Version: 1.0.184-BETA

Note: I'm developing a custom compatibility mod, available at https://github.com/natrow/tfc_minecolonies/tree/1.20.1

Current Behavior

After registering a custom placement handler that requires an ItemStack with a non-one quantity, only a single item is consumed despite the builder (correctly) requesting all the items and the build screen showing all the required items.

Expected Behavior

All the required items should be consumed, not just a single one from the stack

Reproduction Steps
  1. Create and register a PlacementHandler
  2. Override the getRequiredItems() method to return an item stack with a quantity larger than one
  3. Create a build request that will use the affected PlacementHandler
  4. Observe that despite the builder requiring all of the items, only a single one is consumed
Logs

https://pastebin.com/a3hfXgKM

Anything else?
  • Add a thumbs-up to the bug report if you are also affected. This helps the bug report become more visible to the team and doesn't clutter the comments.
  • Add a comment if you have any insights or background information that isn't already part of the conversation.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.