ldtteam / ldtteam/Structurize

[RFC] Smarter blueprint placer

Open
#646 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Compatibility: Vanilla Feature: Request
Dominant language
Java
Stars
55
Forks
53
Avg merge
20m
Merged PRs (30d)
1

Description

State now: placer logic is generally dumb, the only reason it works for most of common blueprints is that it builds from bottom to top.

Potential upgrade:
a) iterate the structure unlimited times (unlike 4 block placement stages now)
b) every iteration place such blocks that BlockState#canSurvive(...) in target world, requires special attention for falling blocks (again...)

Solves:
Blocks requiring support without actually checking for support existence (but falling. blocks..) - dripstones, hanging chains
Removes the relatively new block solidness issue out of placer logic (we still need it elsewhere tho)

Doesn't solve:
Pistons and other blocks which may change size or anyhow change local context

Issues:

  1. need proper optimizations to fast skip blockPoses that are done already (without world blockstate check? skip fully built layers/rows?)
  2. moving redstone blocks (pistons only?) may actually become even worse - solution: special placement handler for powered pistons (mby do additional stage after blocks before entities to check that all redstone blocks incl. actuators are in requested state within one tick)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No source files or tests are named. Start by locating the placer logic and its current four block-placement stages, then inspect how BlockState#canSurvive(...) and falling blocks are handled. Done would require an agreed implementation for repeated placement, optimization, and redstone behavior, plus tests covering the listed cases.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
game-dev
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.