ldtteam / ldtteam/Structurize

Recipe Unlocks Generated Incorrectly

Open
#376 10 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Bug
Dominant language
Java
Stars
55
Forks
53
Avg merge
20m
Merged PRs (30d)
1

Description

Prerequisites
  • I am running the latest alpha version of Structurize for my Minecraft version.
  • I checked the MineColonies/Structurize wiki and made sure my issue is not covered there.
  • I made sure that this issue is not a duplicate of any existing issue.
Context
  • Minecraft Version: 1.16.5
  • Structurize Version: 0.13.172
  • MineColonies Version (if related bug):
  • Related Mods and their Versions:

Expected behavior

Structurize recipes to unlock when acquiring the required materials to craft them when Game Rule 'doLimitedCrafting' is enabled. The recipe unlock advancements are already in the mod, just were not generated correctly.

Actual behavior

Recipes do not unlock.

Steps to reproduce the issue

  1. Start game with GameRule 'doLimitedCrafting' enabled.
  2. Get material needed to craft one of the blocks in structurize, notice it does not unlock
  3. Attempt to craft the block, notice that you cannot
  4. Enter CreativeMode
  5. Give yourself that same block, notice the recipe unlocks
  6. Enter SurvivalMode
  7. Attempt to craft the block, notice that you can.
Logs
  • latest.log:
  • crashlog:
Notes

The vanilla .jar contains plenty of example recipe unlock json to use as example. Since 99% of the blocks in structurize are just generic building blocks, a small script can easily generate the recipe unlock files by reading the recipe files.
https://sourceblock.net/beta/guides/fundamentals/data-packs/advancements/triggers/inventory_changed


Viewers

  • Add a thumbs-up to the bug report if you are also affected. This helps the bug report become more visible to the team and doesn't clutter the comments.
  • Add a comment if you have any insights or background information that isn't already part of the conversation.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the Structurize recipe files and the recipe-unlock advancement JSON generation described in the issue, comparing them with the vanilla examples in the Minecraft jar. Verify the generated advancements against the recipes and test with doLimitedCrafting enabled; done means acquiring required materials unlocks each applicable recipe.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
game-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.