lbryio / lbryio/reflector.go

Upload never returns actual upload errors

Open
#60 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
15
Forks
13
PR merge metrics
No merged PRs in 30d

Description

`reflector.uploader.Upload` never stops or returns an error in case any of the blobs fail to upload, including trivial configuration errors like this:

`MissingRegion: could not find region configuration`

It would be useful to have some error reporting facility there other than logging output.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the reflector.uploader.Upload entry point and reproduce the MissingRegion configuration failure described in the issue. Trace how blob upload failures are currently handled and determine the intended error-reporting path. Done means callers can receive an upload error rather than relying only on logging, including for configuration failures.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
backend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.