lbryio / lbryio/lbrycrd

determine steps to fix getDelayForName in 17.3; we still work around a bug there

Open
#400 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
2.5k
Forks
173
PR merge metrics
No merged PRs in 30d

Description

The 17.4+ codebase had to work around a bug that exists in the previous versions. See https://github.com/lbryio/lbrycrd/blame/v17_master/src/claimtrie/trie.cpp#L921 . It would be nice if we could hard-fork this out in both 17.3 and 17.4+ (aka, v17_master and v19_master) in our next hard fork, but we need to identify the proper fix for it in the 17.3 codebase (aka, master).

Contributor guide

Open the contributing guide

Research direction

Start with src/claimtrie/trie.cpp around line 921 and inspect the blame history for v17_master. Compare getDelayForName in the 17.3 codebase (master) with the workaround in v17_master and v19_master. Done means identifying the proper fix for 17.3 and determining how it should be hard-forked into both codebases.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
blockchain
Issue type
Bug
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.