lbryio / lbryio/lbry-sdk

Add type to supports data

Open
#919 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

area: jsonrpc help wanted level: 1 type: improvement
Dominant language
Python
Stars
7.2k
Forks
493
PR merge metrics
No merged PRs in 30d

Description

## The Issue

Currently, when you list claim information (claim_list_mine/claim_show/resolve/claim_list) that shows supports, you can't tell if it's a classical support or a tip. We should add a type attribute to each support. If someone sends a tip to themselves, it's treated the same way as a classical support, so not sure which way it needs to be captured.

This will be an important field to report of off for search results and have available in the block explorer.

### Expected behaviour
Support should show if it's a tip or not

### Actual behaviour
Can't tell if support is a tip or classic support

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the claim_list_mine, claim_show, resolve, and claim_list implementations to find where support data is assembled. Determine how classical supports and tips, including self-sent tips, are represented, then verify that every named response exposes whether each support is a tip.

Written by the indexing model from the issue text.

Assessment

Tech stack
blockchain, python
Domain
api, blockchain
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.