lbryio / lbryio/lbry-sdk

Check tx size when creating transactions (or use batching for all txes)

Open
#3,712 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
7.2k
Forks
493
PR merge metrics
No merged PRs in 30d

Description

This came from an account fund command that had lots of inputs: ```
TX rejected: transaction 0f47f0fbfced417587bc1e7ad1f78c09d8af204199b644e114a70ac27c03df81 is not standard: weight of transaction 602540 is larger than max allowed weight of 400000```

Only txo spend uses batching, none of the others do, so this can happen with any tx.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the account fund command and transaction-creation paths, then compare them with the txo-spend path that already uses batching. Reproduce the reported oversized transaction and identify all transaction flows that can exceed the maximum weight. Done means those flows either check transaction size or batch inputs so transactions stay within the allowed limit.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
blockchain
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.