support channel sign without adding timestamp to signature
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 7.2k
- Forks
- 493
- PR merge metrics
- No merged PRs in 30d
Description
Basically add a param to make this part optional - https://github.com/lbryio/lbry-sdk/blob/3e3974f81392ae2f95f20487ca08dd4ad2b62922/lbry/extras/daemon/daemon.py#L2975
It can return a bogus release time
Odysee is trying to use these signatures as a URL parameter for verification of unlisted content, so we now need to pass both the signature and signingts, which makes the URL even longer.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in lbry/extras/daemon/daemon.py at the linked code around line 2975 and inspect how the signature and signing timestamp are produced. Add an optional control for omitting the timestamp, while preserving signature verification for URL parameters; done means callers can use the signature without also passing signingts.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- security
- Issue type
- Feature
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 50/100