Updating channel's public key doesn't remove channel part from canonical_url, and doesn't invalidate old signatures for claim_search
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 7.2k
- Forks
- 493
- PR merge metrics
- No merged PRs in 30d
Description
* [ ] This claim has invalid signature and its canonical_url can't be resolved.
`lbrynet claim search --claim_id 627b91a663e00607d58b723370d2f81b69edf57c`
Resolving `canonical_url` from above gives `lbry://@KeyTestChannel:d/testimage:6 has invalid channel signature`
--------------------------
* [ ] Making new signing key for channel, doesn't invalidate old signatures properly for `claim_search`
1. Have a channel with claims on it
2. Update channel's signing key
3. The claims signed with old key are still returned with `lbrynet claim search --channel channel --valid_channel_signature` even though the signatures are now invalid.
This returns 3 claims, but only 1 has valid channel signature.
`lbrynet claim search --channel @keytestchannel --valid_channel_signature`
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the two `lbrynet claim search` commands in the issue and trace canonical URL resolution and channel-signature filtering after a channel signing-key update. Done means invalid claims no longer retain the channel component in their canonical URL, and `--valid_channel_signature` excludes claims signed with the old key.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend-api-design, cryptography, search
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100