lbryio / lbryio/lbry-sdk

`lbrynet --help` output seems bit incorrect

Open
#3,639 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
7.2k
Forks
493
PR merge metrics
No merged PRs in 30d

Description

Running lbrynet --help returns following:

$ lbrynet --help
Usage:  lbrynet [-v] [--api HOST:PORT] [--audio-encoder AUDIO_ENCODER]
                [--config FILE] [--ffmpeg-path FFMPEG_PATH]
                [--video-bitrate-maximum VIDEO_BITRATE_MAXIMUM]
                [--video-encoder VIDEO_ENCODER] [--video-scaler VIDEO_SCALER]
                [--volume-analysis-time VOLUME_ANALYSIS_TIME]
                [--volume-filter VOLUME_FILTER]
                COMMAND ...
.
.
.

But starting lbrynet following that format, doesn't seem to make options used to take effect.

For example, this doesn't make api listen to port set in command:
lbrynet --api 0.0.0.0:11111 start

(This would work and lbrynet start --help does show the option in its output:
lbrynet start --api 0.0.0.0:11111)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the lbrynet command entry point and reproduce both command forms shown in the report, comparing how options before and after COMMAND are handled. Done means the documented lbrynet --api HOST:PORT start form applies the API address, or the help output accurately reflects the supported ordering.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
cli
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.