Support methods should work with claim names as well
Open
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 7.2k
- Forks
- 493
- PR merge metrics
- No merged PRs in 30d
Description
Currently support_create and support_abandon only support claim_id as input.
It would be good if we could use a claim URI, name or channel name directly.
lbrynet support create --claim_id=5a23d1ca8cb8e6926902c5beafd725682bfac048 "10.0"
lbrynet support create "fight-the-SEC" "10.0"
lbrynet support create --claim_id=3fda836a92faaceedfe398225fb9b2ee2ed1f01a --keep="50.0"
lbrynet support create "@lbry:3f" --keep="50.0"
In my personal code I first do a claim_search on the URI or name to get the claim_id, and then pass it to support_create or support_abandon.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the linked sections of lbry/extras/daemon/daemon.py around support_create and support_abandon, then trace how the lbrynet support commands pass their arguments. The change is complete when both methods accept a claim URI, claim name, or channel name directly while preserving claim_id support, as shown by the issue's command examples.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend, cli
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100