lbryio / lbryio/lbry-sdk

sanitize sensitive variables

Open
#3,374 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
7.2k
Forks
493
PR merge metrics
No merged PRs in 30d

Description

You have that variable that contain private data. Also sometime you use the log.exception method.
In this case you can cause situation where private data could be compromated in your logs.
https://github.com/lbryio/lbry-sdk/blob/bce299ccc725bebb353d57efe50228e0f8cc8f1e/lbry/wallet/transaction.py#L880

will be better to sanitize logs and tracebacks by some dictonary with sensitive variables.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at lbry/wallet/transaction.py around line 880 and inspect the log.exception usage and the private data it may expose. Trace related logging and traceback paths to determine the scope of sensitive variables. Done means sensitive values are consistently sanitized without removing useful diagnostic context, with coverage for the affected logging behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
security
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.