lbryio / lbryio/lbry-sdk

Use feature signaling instead of version checks

Open
#3,341 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
7.2k
Forks
493
PR merge metrics
No merged PRs in 30d

Description

Problem

  • You don't know in advance what version your code will be released in, so you cannot depend on it in your code
  • Checking if a feature is available is a more direct check than checking the version number

Solution

Whenever possible, just try the feature directly and if it is not available then you know it's not available.

For other things, add a field to .... some api call that signals which features are available.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue names no files, tests, or specific API entry point. Start by locating version checks and the API calls that expose feature availability; define the affected scope and verify that callers can detect unsupported features without relying on release versions.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
api, backend-api-design
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.