lbryio / lbryio/lbry-sdk

Ask for confirmation before purchasing a claim

Open
#3,340 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
7.2k
Forks
493
PR merge metrics
No merged PRs in 30d

Description

My request is that when you run "lbrynet get " and the claim has to be purchased, ask for confirmation (y/N) first, because currently it instantly purchases the claim.
I don't know whether this would break something when used through a GUI where the confirmation is asked for by the application so a workaround could be an option called "--force-purchase" or similar to skip the confirmation in these cases. That's just an idea, maybe there's a better way of doing that.
The reason I'm reporting this as an issue is because I accidentally bought a claim, when running a script.
Luckily it was only $3.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the lbrynet get <uri> command entry point and trace the purchase path. Compare interactive CLI use with GUI or script callers; done is a confirmed purchase flow that prevents accidental purchases while preserving an explicit path for callers that cannot answer prompts.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
blockchain, cli, payments
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.