lbryio / lbryio/lbry-sdk

wallet sync does not take into account address gaps

Open
#3,231 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

type: bug
Dominant language
Python
Stars
7.2k
Forks
493
PR merge metrics
No merged PRs in 30d

Description

Niko had a strange issue with his wallet which we're not sure how it got into (but there's a known bug with gaps: https://github.com/lbryio/lbry-sdk/issues/3230 that could have caused it)

His wallet sync data would flip flop between desktop and web because the gaps were different in each, but sync apply would not update the gaps since the modified at was the same:

image

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading the linked wallet-gap issue (#3230) and tracing the wallet sync and sync apply paths described here. Determine how equal modified-at values affect gap updates, then verify that desktop and web wallet sync data no longer flip-flops when their address gaps differ.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend, distributed-systems
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.