max address gap not set properly
Open
Nobody has claimed this yet.
type: bug
- Dominant language
- Python
- Stars
- 7.2k
- Forks
- 493
- PR merge metrics
- No merged PRs in 30d
Description
There are old wallets that don't set the gap properly and won't sync the right data. I have some examples when this issue is ready to be worked on:
on initial sync:
2020-11-19 00:04:38,978 INFO lbry.wallet.ledger:1073: Loaded account bbqEnWGbfw3jyw1tu5YHaT9hHZcCGS9bLt with 0.001296 LBC, 43 receiving addresses (gap: 22), 17 change addresses (gap: 6), 0 channels, 0 certificates and 0 claims.
after fixing gaps:
2020-11-19 00:07:08,587 INFO lbry.wallet.ledger:1073: Loaded account bbqEnWGbfw3jyw1tu5YHaT9hHZcCGS9bLt with 1.42428807 LBC, 342 receiving addresses (gap: 33), 110 change addresses (gap: 6), 0 channels, 0 certificates and 0 claims.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at lbry.wallet.ledger:1073 and trace the initial account sync and gap calculation described in the logs. Compare the receiving and change gap values before and after fixing gaps; done means old wallets discover the correct addresses and balances during synchronization.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- blockchain
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100