transaction notification on clients sometimes doesn't happen until 2 new blocks come in
A pull request for this has already been merged.
- Dominant language
- Python
- Stars
- 7.2k
- Forks
- 493
- PR merge metrics
- No merged PRs in 30d
Description
Had it happen to me twice recently, even before the latest version. The last time, I think it waited for 2 blocks (may have published right around the time of the first one) for it to return from the blocking call. As soon as I saw the block come in, the publish finished.
We are also seeing timeouts on lbry.tv which could be related to this.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No files or tests are named. Start by tracing the transaction notification blocking call and how new blocks release it, then compare that path with the reported lbry.tv timeouts. Done means the notification does not wait for an unexpected extra block and a regression test covers the timing case.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- blockchain, python
- Domain
- blockchain, distributed-systems
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100