timeout subscribing to addresses - increase timeout?
Open
Nobody has claimed this yet.
type: bug
- Dominant language
- Python
- Stars
- 7.2k
- Forks
- 493
- PR merge metrics
- No merged PRs in 30d
Description
This happens on heavier wallets / addresses (youtube sync users, spee.ch, single lbry.tv addresses)
@jackrobison this would be nice to increase with your recent sync changes to see if it helps with any of the data integrity issues.
2020-03-17 16:30:12,238 WARNING lbry.wallet.network:288: timed out subscribing to addresses from 216.19.244.55:50001
Task exception was never retrieved
future: <Task finished coro=<RPCSession.send_request() done, defined at /home/tom/lbry/lbry/wallet/rpc/session.py:455> exception=TimeoutError()>
Traceback (most recent call last):
File "/home/tom/lbry/lbry/wallet/rpc/session.py", line 464, in send_request
raise result
concurrent.futures._base.TimeoutError
Task exception was never retrieved
future: <Task finished coro=<RPCSession.send_request() done, defined at /home/tom/lbry/lbry/wallet/rpc/session.py:455> exception=TimeoutError()>
Traceback (most recent call last):
File "/home/tom/lbry/lbry/wallet/rpc/session.py", line 464, in send_request
raise result
File "/home/tom/lbry/lbry/wallet/rpc/session.py", line 464, in send_request
raise result
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Review lbry/wallet/network.py around line 288 and lbry/wallet/rpc/session.py around lines 455-464, then reproduce the timeout with a heavier wallet or address. Determine whether the subscription timeout should change and validate the result against the reported data-integrity concern.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend, networking
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100