lbryio / lbryio/lbry-sdk

overwrite (or merge?) preference data on sync apply

Open
#2,829 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

area: wallet
Dominant language
Python
Stars
7.2k
Forks
493
PR merge metrics
No merged PRs in 30d

Description

If the timestamp of the sync is older than the local timestamp int he wallet preferences, sync is not applied for those. In some cases, we may want to overwrite this or merge the preferences./

Overwriting may be easier for now, but if we want to merge, we'd need to discuss specifics.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No files or tests are identified. Start by locating the sync-apply logic and the wallet preference timestamp check, then clarify whether older sync data should overwrite local preferences or be merged. Done requires an agreed behavior and corresponding coverage for that choice.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
distributed-systems
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.