lbryio / lbryio/lbry-sdk

Remove claim id from canonical URL when it contains a channel with a claim id

Open
#2,425 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

consider soon type: improvement
Dominant language
Python
Stars
7.2k
Forks
493
PR merge metrics
No merged PRs in 30d

Description

Per discussion with @lbryio/appsquad and @kauffj, we think the SDK should provide a cleaner/clearer canonical URL when a channel is present that doesn't include a short ID on the claim. 99.99% of the time, we won't have 2 of the same claim names on a channel, so we should drop the short url suffix on the claim name when a channel exists.

The app does not allow publishing to the same claim name twice in the same wallet, and we don't plan to change this.

Old discussion: https://lbryians.slack.com/archives/C81K0BM9A/p1559066090050600

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue names no files or tests; begin by locating the SDK's canonical URL generation entry point and reviewing how channel claims and short IDs are represented. Use the stated channel-with-claim behavior and the linked historical discussion to define regression coverage, with completion shown by canonical URLs omitting the claim short ID when a channel is present.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend-api-design
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.