add disconnect messages to blob exchange protocols
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 7.2k
- Forks
- 493
- PR merge metrics
- No merged PRs in 30d
Description
There is no way for us to tell if a client disconnects because it no longer needs the connection or because of other network issues. This makes it very hard to debug reflector issues or connection issues.
Goal: add a Disconnect message type to the peer and reflector protocols.
For BC, we should first add the message type and message handling, but not send any disconnect messages. After releasing that code, later start sending disconnect messages. Then eventually start logging disconnects that did not include this message.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the peer and reflector protocol implementations and their existing message-handling paths. For this first stage, done means defining and handling a Disconnect message in both protocols without sending it; later sending and logging behavior is explicitly deferred.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- networking
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100