lbryio / lbryio/lbry-sdk

Add error code for claims that are abandonded

Open
#2,188 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

area: api
Dominant language
Python
Stars
7.2k
Forks
493
PR merge metrics
No merged PRs in 30d

Description

The Issue

I would like to make a suggestion for the first error code to officially add

Now that the ui will be displaying all of your subscriptions, we need to unsubscribe from channels that have been abandoned.

Ideally it would look something like this

Lbry.resolve(...)
  .then(result => {
    if (result[uri].error_code === ABANDONED_CLAIM_ERROR_CODE) {
       unsubscibe(uri)
    }
    ...

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the Lbry.resolve entry point and inspect how claim resolution currently reports errors. Define completion as returning a distinct error code for abandoned claims so callers can detect it with result[uri].error_code and unsubscribe the channel.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
api, blockchain
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.