lbryio / lbryio/lbry-sdk

Capture non-DHT related get errors in analytics

Open
#2,011 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

area: jsonrpc icebox priority: low type: improvement
Dominant language
Python
Stars
7.2k
Forks
493
PR merge metrics
No merged PRs in 30d

Description

## The Issue
We used to have get failures for reasons outside of sd/blob timeout, but they are no longer being captured. Some examples included: not enough disk space, no access to download location, max kee fee errors, and more exotic ones like `'NoneType' object is not subscriptable`. This can give us additional insights as to why users experience download issues.

## System Configuration

- LBRY Daemon version:
- LBRY App version:
- LBRY Installation ID:
- Operating system:

## Anything Else

## Screenshots

## Internal Use

### Acceptance Criteria
1.
2.
3.

### Definition of Done
- [ ] Tested against acceptance criteria
- [ ] Tested against the assumptions of user story
- [ ] The project builds without errors
- [ ] Unit tests are written and passing
- [ ] Tests on devices/browsers listed in the issue have passed
- [ ] QA performed & issues resolved
- [ ] Refactoring completed
- [ ] Any configuration or build changes documented
- [ ] Documentation updated
- [ ] Peer Code Review performed

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No files, tests, or entry points are named. Start by tracing the get failure handling and analytics reporting, then identify where non-DHT errors such as disk-space or download-location failures stop being captured. Done means these errors are recorded in analytics, with unit tests covering the relevant failure cases.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
28/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.