LBRY_API env var should be renamed to LBRYNET_API to avoid conflicts
Open
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 7.2k
- Forks
- 493
- PR merge metrics
- No merged PRs in 30d
Description
The Issue
Up until lbrynet 0.30 LBRY_API was not parsed (or at least considered) by the SDK, LBRY_API often refers to our internal apis and serveral other projects rely on that environment variable to function.
With lbrynet 0.31, setting LBRY_API to an endpoint different than the default one obviously breaks lbrynet.
Steps to reproduce
- set LBRY_API to something like https://api.lbry.io
- try to start lbrynet
- if lbrynet starts, the API won't work
System Configuration
lbrynet > 0.30
Internal Use
Acceptance Criteria
Definition of Done
- Tested against acceptance criteria
- Tested against the assumptions of user story
- The project builds without errors
- Unit tests are written and passing
- Tests on devices/browsers listed in the issue have passed
- QA performed & issues resolved
- Refactoring completed
- Any configuration or build changes documented
- Documentation updated
- Peer Code Review performed
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Search the repository for LBRY_API and the SDK startup or configuration entry points, then identify related tests and documentation. The work is done when the environment-variable references, tests, and documentation consistently use LBRYNET_API and the endpoint behavior is covered.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- api, backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100