lbryio / lbryio/lbry-sdk

Resolve, claim_show, and claim_list_mine return different claim signatures

Open
#1,008 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

area: jsonrpc level: 2 type: bug
Dominant language
Python
Stars
7.2k
Forks
493
PR merge metrics
No merged PRs in 30d

Description

Specifically, the `category` field is missing from resolve, but there may be other differences.

#### resolve (missing category sub-field)
```
./lbrynet-cli resolve squirreltryingtohidenutinadog
{
"squirreltryingtohidenutinadog": {
"claim": {
"address": "bWTLALD64DDHmg9DieNUWrkd6Uzh4XrRRp",
"amount": 10.0,
"claim_id": "240e7ce3ae3bd40c728412af9964270f1ee5b7e8",
"claim_sequence": 1,
"decoded_claim": true,
"depth": 24942,
"effective_amount": 10.0,
"has_signature": false,
"height": 254705,
"hex": "080110011ad7010801128001080410011a20546865204265737420506c61636520546f204869646520596f7572204e7574732224537175697272656c20747269657320746f2068696465206e757420696e206120646f672e2a00320d5075626c696320446f6d61696e38004a1b687474703a2f2f737065652e63682f737175697272656c2e706e6752005a001a50080110011a3086d7df8f9b7fa0ef92177859bc20c72ca7d7116d76eefcd99e812e6a462639ea231f0fffa12fa5b7acc33f727df0c54c22186170706c69636174696f6e2f6f637465742d73747265616d",
"name": "squirreltryingtohidenutinadog",
"nout": 1,
"supports": [],
"txid": "44a4c20e4fe88a7d063703cdaa62c45fa08c7103230950d7501fb4418a32355d",
"value": {
"claimType": "streamType",
"stream": {
"metadata": {
"author": "",
"description": "Squirrel tries to hide nut in a dog.",
"language": "en",
"license": "Public Domain",
"licenseUrl": "",
"nsfw": false,
"preview": "",
"thumbnail": "http://spee.ch/squirrel.png",
"title": "The Best Place To Hide Your Nuts",
"version": "_0_1_0"
},
"source": {
"contentType": "application/octet-stream",
"source": "86d7df8f9b7fa0ef92177859bc20c72ca7d7116d76eefcd99e812e6a462639ea231f0fffa12fa5b7acc33f727df0c54c",
"sourceType": "lbry_sd_hash",
"version": "_0_0_1"
},
"version": "_0_0_1"
},
"version": "_0_0_1"
}
}
}
}
```

#### claim_show (also omits category)
```
./lbrynet-cli claim_show --claim_id=240e7ce3ae3bd40c728412af9964270f1ee5b7e8
{
"address": "bWTLALD64DDHmg9DieNUWrkd6Uzh4XrRRp",
"amount": 10.0,
"claim_id": "240e7ce3ae3bd40c728412af9964270f1ee5b7e8",
"claim_sequence": 1,
"decoded_claim": true,
"depth": 24944,
"effective_amount": 10.0,
"has_signature": false,
"height": 254705,
"hex": "080110011ad7010801128001080410011a20546865204265737420506c61636520546f204869646520596f7572204e7574732224537175697272656c20747269657320746f2068696465206e757420696e206120646f672e2a00320d5075626c696320446f6d61696e38004a1b687474703a2f2f737065652e63682f737175697272656c2e706e6752005a001a50080110011a3086d7df8f9b7fa0ef92177859bc20c72ca7d7116d76eefcd99e812e6a462639ea231f0fffa12fa5b7acc33f727df0c54c22186170706c69636174696f6e2f6f637465742d73747265616d",
"name": "squirreltryingtohidenutinadog",
"nout": 1,
"supports": [],
"txid": "44a4c20e4fe88a7d063703cdaa62c45fa08c7103230950d7501fb4418a32355d",
"valid_at_height": 254705,
"value": {
"claimType": "streamType",
"stream": {
"metadata": {
"author": "",
"description": "Squirrel tries to hide nut in a dog.",
"language": "en",
"license": "Public Domain",
"licenseUrl": "",
"nsfw": false,
"preview": "",
"thumbnail": "http://spee.ch/squirrel.png",
"title": "The Best Place To Hide Your Nuts",
"version": "_0_1_0"
},
"source": {
"contentType": "application/octet-stream",
"source": "86d7df8f9b7fa0ef92177859bc20c72ca7d7116d76eefcd99e812e6a462639ea231f0fffa12fa5b7acc33f727df0c54c",
"sourceType": "lbry_sd_hash",
"version": "_0_0_1"
},
"version": "_0_0_1"
},
"version": "_0_0_1"
}
}
```

#### claim_list_mine (includes category)
```
./lbrynet-cli claim_list_mine
...
{
"address": "bWTLALD64DDHmg9DieNUWrkd6Uzh4XrRRp",
"amount": 10.0,
"blocks_to_expiration": 238030,
"category": "claim",
"claim_id": "240e7ce3ae3bd40c728412af9964270f1ee5b7e8",
"confirmations": 24944,
"decoded_claim": true,
"expiration_height": 517679,
"expired": false,
"has_signature": false,
"height": 254705,
"is_pending": false,
"is_spent": false,
"name": "squirreltryingtohidenutinadog",
"nout": 1,
"txid": "44a4c20e4fe88a7d063703cdaa62c45fa08c7103230950d7501fb4418a32355d",
"value": {
"claimType": "streamType",
"stream": {
"metadata": {
"author": "",
"description": "Squirrel tries to hide nut in a dog.",
"language": "en",
"license": "Public Domain",
"licenseUrl": "",
"nsfw": false,
"preview": "",
"thumbnail": "http://spee.ch/squirrel.png",
"title": "The Best Place To Hide Your Nuts",
"version": "_0_1_0"
},
"source": {
"contentType": "application/octet-stream",
"source": "86d7df8f9b7fa0ef92177859bc20c72ca7d7116d76eefcd99e812e6a462639ea231f0fffa12fa5b7acc33f727df0c54c",
"sourceType": "lbry_sd_hash",
"version": "_0_0_1"
},
"version": "_0_0_1"
},
"version": "_0_0_1"
}
},
...
```

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the outputs from the `resolve`, `claim_show`, and `claim_list_mine` commands shown in the issue, then trace how each command constructs its claim response. Compare the returned fields and make the claim signatures consistent, with tests or command output demonstrating that the fields match.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
api, cli
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.