lbryio / lbryio/lbry-redux

CORS Error when canceling publish on Odysee / LBRY

Open
#388 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
15
Forks
40
PR merge metrics
No merged PRs in 30d

Description

https://github.com/lbryio/lbry-redux/blob/c31161c41a54f6e05e7a75de54f86629eafec0e0/src/redux/actions/publish.js#L19

This function causes a CORS error client side:

![image](https://user-images.githubusercontent.com/45262335/111043504-ccbc8600-83f7-11eb-926b-2890525de3c7.png)

https://spee.ch/api/config/site/publishing 302 redirections to -> https://lbry2.vanwanet.com/speech/api/config/site/publishing

The redirection on spee.ch has proper CORS, however the location at lbry2.vanwanet.com does not have any CORs set.

@tzarebczan suggested removing the check entirely.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in src/redux/actions/publish.js at the linked line and inspect the function used when canceling a publish. Reproduce the cancellation request if possible and compare the redirect to the CORS behavior described for spee.ch and lbry2.vanwanet.com. Done means canceling a publish no longer triggers the reported client-side CORS error.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.