Add error when display type not passed to doNotify
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 15
- Forks
- 40
- PR merge metrics
- No merged PRs in 30d
Description
## The Issue
Per comments in https://github.com/lbryio/lbry-app/pull/1493#issuecomment-390298790, we should add an error when the doNotify function does not contain all required parameters. If we don't, the notifications get queued up and other notifications don't show afterwards.
## System Configuration
- LBRY Daemon version:
- LBRY App version:
- LBRY Installation ID:
- Operating system:
## Anything Else
## Screenshots
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the doNotify function in the shared app components and review how its required parameters are handled. Add an error when the display type is missing or required parameters are incomplete, then verify that notifications no longer remain queued and block later notifications.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100