lbryio / lbryio/lbry-desktop

Use fee estimator to show estimated fee on spend confirm screen

Open
#903 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

area: ux hacktoberfest help wanted level: 2 priority: low type: improvement
Dominant language
JavaScript
Stars
3.5k
Forks
409
PR merge metrics
No merged PRs in 30d

Description

## The Issue
If a user tries to send their entire LBC balance to an address (not taking into account tx fees), they are presented with the "get credits" modal and the LBC is not sent. We should mention that transaction fees are associated with sending credits. I'm not sure if we have a way to estimate what those fees are right now (it depends on how many UTXOs are part of of the tx), but we should at least have a better message.

Once we do have the fees, we should have a button called "send max" which takes into account the tx fees.

### Steps to reproduce
1. Send entire LBC balance
2. Get message about credits

## System Configuration

- LBRY Daemon version: 0.18.0
- LBRY App version: 0.19.2
- LBRY Installation ID:
- Operating system:

## Anything Else

## Screenshots

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the spend-confirm flow described in the issue: try sending the entire LBC balance and observe the “get credits” message. Trace the fee-estimation entry point and confirm how the spend screen handles transaction fees; done means the screen shows the estimated fee and provides a working “send max” option that accounts for it.

Written by the indexing model from the issue text.

Assessment

Tech stack
electron, javascript, react
Domain
blockchain, frontend, payments
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.