Linting errors fixable with `--fix`
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 3.5k
- Forks
- 409
- PR merge metrics
- No merged PRs in 30d
Description
Currently, the project contains a ton of lint errors that get can and will get autofixed by running `yarn lint` . This adds several modified files to a commit / PR and therefore not helpful at the current stage.
## The Issue
### Steps to Reproduce
1. Create new branch
2. Run `yarn flow`
3. Run `git status`
### Expected Behaviour
No changes made, because master is clean of autifixable errors
### Actual Behaviour
Tons of modified files
### Suggested Solutions
My suggestion would be fixing each of those files in seperate PRs. One big PR would probably create a lot of merge conflicts for branches currently worked on. Modifying one of those files will prompt you to fix any other errors before commit. Might be a good time to do so :)
- [ ] main/index.js
- [x] renderer/component/address/index.js
- [x] renderer/component/button/index.js
- [ ] renderer/component/cardMedia/index.js
- [x] renderer/component/channelTile/index.js
- [x] renderer/component/common/credit-amount.jsx
- [ ] renderer/component/common/file-exporter.jsx
- [x] renderer/component/dateTime/index.js
- [x] renderer/component/externalLink/index.js
- [x] renderer/component/fileActions/index.js
- [x] renderer/component/fileDetails/index.js
- [ ] renderer/component/fileDetails/view.jsx
- [x] renderer/component/filePrice/index.js
- [ ] renderer/component/formFieldPrice/index.js
- [x] renderer/component/nsfwOverlay/index.js
- [ ] renderer/component/publishForm/index.js
- [x] renderer/component/router/index.js
- [ ] renderer/component/selectChannel/index.js
- [x] renderer/component/shapeShift/index.js
- [x] renderer/component/snackBar/index.js
- [x] renderer/component/spinner/index.js
- [ ] renderer/component/theme/index.js
- [x] renderer/component/transactionListRecent/index.js
- [x] renderer/component/uriIndicator/index.js
- [ ] renderer/component/userVerify/view.jsx
- [x] renderer/component/walletAddress/index.js
- [x] renderer/component/walletBalance/index.js
- [x] renderer/component/walletSend/index.js
- [ ] renderer/component/walletSendTip/index.js
- [ ] renderer/modal/modalAffirmPurchase/index.js
- [ ] renderer/modal/modalAuthFailure/index.js
- [ ] renderer/modal/modalAutoUpdateConfirm/index.js
- [ ] renderer/modal/modalAutoUpdateDownloaded/index.js
- [ ] renderer/modal/modalConfirmTransaction/index.js
- [ ] renderer/modal/modalError/index.js
- [ ] renderer/modal/modalFileTimeout/index.js
- [ ] renderer/modal/modalFirstSubscription/index.js
- [ ] renderer/modal/modalIncompatibleDaemon/index.js
- [ ] renderer/modal/modalOpenExternalLink/index.js
- [ ] renderer/modal/modalPublish/index.js
- [ ] renderer/modal/modalRemoveFile/index.js
- [ ] renderer/modal/modalRevokeClaim/index.js
- [ ] renderer/modal/modalRewardApprovalRequired/index.js
- [ ] renderer/modal/modalSendTip/index.js
- [ ] renderer/modal/modalTransactionFailed/index.js
- [ ] renderer/modal/modalWelcome/index.js
- [ ] renderer/page/backup/index.js
- [ ] renderer/page/getCredits/index.js
- [ ] renderer/page/report/index.js
- [ ] renderer/page/sendCredits/index.js
- [ ] renderer/page/show/index.js
- [ ] renderer/page/transactionHistory/index.js
- [ ] renderer/page/userHistory/index.js
- [ ] renderer/page/wallet/index.js
- [ ] renderer/redux/reducers/shape_shift.js
- [ ] renderer/redux/selectors/content.js
## System Configuration
Not important. Can be done without actually running the project.
### Acceptance Criteria
1. Files don't get modified by `yarn lint` on a fresh branch
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start on a fresh branch by running `yarn lint` and checking the listed unchecked files, such as `main/index.js`, the remaining renderer components, modals, pages, and Redux files. Work through the files named in the issue and rerun the lint command; done means linting no longer modifies tracked files.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- tooling
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100