lbryio / lbryio/lbry-desktop

Flow type errors

Open
#2,024 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

hacktoberfest help wanted
Dominant language
JavaScript
Stars
3.5k
Forks
409
PR merge metrics
No merged PRs in 30d

Description

We are currently trying to use [Flow](https://flow.org/) in every file. We have been slowly making progress but there are still a lot of errors.

If you open a PR with some Flow error fixes (or anything else) we will send you some LBC as appreciation!

Some of the biggest offenders right now are in `pages/file/view.jsx` and anything with subscriptions.

To see all of the errors you can run `./node_modules/.bin/flow --color always`

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Run ./node_modules/.bin/flow --color always to see the current errors, then start with pages/file/view.jsx or the subscription-related errors named in the issue. Review the reported locations and confirm that the Flow check completes without those errors; the issue leaves the overall scope open-ended.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, react
Domain
frontend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.