lbryio / lbryio/lbry-desktop

Web Content Should Open in a Web Type View

Open
#1,682 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

area: viewer help wanted level: 1 type: improvement
Dominant language
JavaScript
Stars
3.5k
Forks
409
PR merge metrics
No merged PRs in 30d

Description

Having self-contained and `lbry://` interlinkable websites is a big selling point for LBRY. However, viewing HTML content is in need of some love. It would be nice to have HTML/web documents open up in fullscreen below the new header, to make the experience more enjoyable.

I also noticed anchor links and context menus don't work with HTML content.

At the time of writing this, this web content I uploaded can be viewed which relates to the above.

lbry://nine#9b6eefab8def087ae26ef900bf62dc0113fe1cfb

![image](https://user-images.githubusercontent.com/29914179/41841447-a11809d4-78ab-11e8-8486-16af785d7e7d.png)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the linked lbry:// web content and inspect how HTML content is currently displayed. The work is done when web documents open fullscreen below the header and anchor links and context menus work in HTML content.

Written by the indexing model from the issue text.

Assessment

Tech stack
electron, javascript, react
Domain
frontend, web-dev
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.