lbryio / lbryio/lbry-android

Searching while offline says no results found

Open
#990 1 comment 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

type: improvement
Dominant language
Java
Stars
2.4k
Forks
110
PR merge metrics
No merged PRs in 30d

Description

DESCRIPTION:

Searching while offline say no results found and that the user should try another term. If the user is not aware they are offline, they may be led to believe that the item they searched for doesn't exist when it does, or that LBRY's search algorithms are poor.


REPRO STEPS:

  1. Install and Launch LBRY 0.16.0 on Android 8.1.0
  2. Go offline
  3. Search for something that definitely exists

Results: User is told no results

Expected: User is told they are offline


ENVIRONMENT:

  • LG V20
  • Android 8.1.0
  • LBRY 0.16.0

MEDIA:

Screenshot_20200822-131050_LBRY


INTERNAL USE:


DEFINITION OF DONE:

  • Tested against acceptance criteria
  • Tested against the assumptions of the user story
  • The project builds without errors
  • Unit tests are written and passing
  • Tests on devices/browsers listed in the issue have passed
  • QA performed & issues resolved
  • Refactoring completed
  • Any configuration or build changes documented
  • Documentation updated
  • Peer Code Review performed

LBRY ADDRESS:
bZSqrVdpxt5KJdn2eGMUzT9Jn3gEiRet7b
mail@cahlen.org

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the search flow on Android 8.1.0 while offline, then trace how the search failure is turned into the no-results message. The change is done when offline searches tell the user they are offline instead, the project builds, and unit tests cover the behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
android, java
Domain
mobile, search
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.