lbryio / lbryio/lbry-android

allow sign out

Open
#747 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

app-parity type: new feature
Dominant language
Java
Stars
2.4k
Forks
110
PR merge metrics
No merged PRs in 30d

Description

Signing out of the application should be possible now that we show the signed-in account. It should clear the auth token for sure. Stored password too?

Should it clear the wallet out? If we don't and they sign in on another account, the wallet may not get unlocked properly - we'd need to prompt them for the password. If it is unlocked, the wallets would get merged if they sign in and sync. This is the reason why I think it's safer to clear out the wallet.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No file, test, or entry point is named. Trace the signed-in account, auth-token, stored-password, and wallet handling, then clarify the intended cleanup behavior before implementing sign out; done means signing out safely separates the current account and prevents wallet merging.

Written by the indexing model from the issue text.

Assessment

Tech stack
android, java
Domain
authentication, mobile, security
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.