lbryio / lbryio/lbry-android

Background service doesn't stop on closing app

Open
#1,178 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Java
Stars
2.4k
Forks
110
PR merge metrics
No merged PRs in 30d

Description

l

The Issue

I want lbry's videos to play in the background, but only when the app hasn't been 'swiped'. However even after swiping, there is a persistent notification saying that lbry is playing in the background.

I tried to follow what was here (https://lbry.com/faq/android-basics#stoplbryservice), though I'm not sure because I don't exactly see the setting named "Keep the daemon background service running after closing the app".

Steps to reproduce
  1. Enable background playback
  2. Disable background service (in the 'other' section)
  3. Swipe the app
Expected behaviour

No trace of lbry after swiping.

Actual behaviour

Persistent/ongoing notification saying that the lbry service is playing in the background with a "stop" buttion. I have to press this everytime I close the app.

System Configuration

  • Device: Galaxy s20
  • Android version: 10

Anything Else

Screenshots

(Will add, give me some time)

Internal Use

Acceptance Criteria

The persistent notification shouldn't show. Disabling notifications is not an option.

Definition of Done
  • Tested against acceptance criteria
  • Tested against the assumptions of the user story
  • The project builds without errors
  • Unit tests are written and passing
  • Tests on devices/browsers listed in the issue have passed
  • QA performed & issues resolved
  • Refactoring completed
  • Any configuration or build changes documented
  • Documentation updated
  • Peer Code Review performed

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the issue on Android 10 with a Galaxy S20 using the listed background-playback and background-service settings, then inspect the app's background service and notification lifecycle. Done means swiping the app after disabling the background service leaves no persistent LBRY notification, with the project building and relevant tests passing.

Written by the indexing model from the issue text.

Assessment

Tech stack
android, java
Domain
mobile
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.