lbryio / lbryio/lbry-android

Extract dimension values into resource files

Open
#1,151 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Java
Stars
2.4k
Forks
110
PR merge metrics
No merged PRs in 30d

Description

## The Issue
Most layouts are using hard-coded dimension values and font sizes. Although this is not a problem with current layouts, as they are not optimized for any screen size/pixel density, in order to improve how app looks in larger screen devices -like tablets and TVs-, it helps to be able to set those dimensions accordingly instead of having to duplicate layouts and changing the hard-coded dimensions on the new ones.

### Steps to reproduce
1. Open the app on different screen density devices

### Expected behaviour
Layout is optimized
### Actual behaviour
Tell us what happeEverything looks wrong, specifically text size, which seems too much small on larger screen devices, wasting a lot of space

### Related Issues
#693 and #798

## Internal Use

### Acceptance Criteria
1.
2.
3.

### Definition of Done
- [ ] Tested against acceptance criteria
- [ ] Tested against the assumptions of the user story
- [ ] The project builds without errors
- [ ] Unit tests are written and passing
- [ ] Tests on devices/browsers listed in the issue have passed
- [ ] QA performed & issues resolved
- [ ] Refactoring completed
- [ ] Any configuration or build changes documented
- [ ] Documentation updated
- [ ] Peer Code Review performed

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue does not name specific files or tests; start by locating the app's layout files and existing dimension or font resource files. Determine which hard-coded values need extraction and how screen density is currently handled. Done means the layouts use resource-based dimensions, larger-density devices are improved, and the project builds with relevant tests passing.

Written by the indexing model from the issue text.

Assessment

Tech stack
android
Domain
design, mobile
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
28/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.