lbryio / lbryio/lbry-android

Tag Text Character Count is Unlimited and Allows Carriage Return

Open
#1,106 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Java
Stars
2.4k
Forks
110
PR merge metrics
No merged PRs in 30d

Description

**DESCRIPTION:**

When editing Tags in the Channel menu, the user is allowed to enter an unlimited amount of text including carriage returns. This allows the creation of very large Tag boxes and makes the app vulnerable to other failure possibilities.

-----

**REPRO STEPS:**
1) Open LBRY 0.16.11 on Android 8.1.0 w/ a Synced Account and Daemon Running
2) Go to your Channel
3) Click the Edit button
4) Click 'Show Optional Fields'
5) Copy a large amount of text from another source
6) Paste the text into the 'Search for more tags' field

**Results:** Field allows unlimited text and carriage returns

**Expected:** Field limits character count and does not allow carriage returns

-----

**MEDIA**

![UnlimitedTagText](https://user-images.githubusercontent.com/30788194/103302491-0cf79500-49c1-11eb-85ab-65e0824498e8.gif)

-----

**ENVIRONMENT:**

- LG V20
- Android 8.1.0
- LBRY 0.16.11

-----

**LBRY ADDRESS:**
bZSqrVdpxt5KJdn2eGMUzT9Jn3gEiRet7b
mail@cahlen.org

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the Android channel editing flow described in the reproduction steps and inspect the “Search for more tags” field. Reproduce the large paste and carriage-return cases, then verify that the field enforces a character limit and rejects carriage returns.

Written by the indexing model from the issue text.

Assessment

Tech stack
android, java
Domain
mobile
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.